[DNM][AMD] agentx-v0.4#1654
Conversation
… Kimi/Qwen scripts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… to 32 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
2 similar comments
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
… Kimi/MiniMax scripts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
….0, expand conc list Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…higher range Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… and update script Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d update scripts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…standalone script Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…nd script Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…2.5 agentic configs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… cap) for 0607 trial Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lmcache DRAM, add org script - Switch WEKA_LOADER_OVERRIDE to semianalysis_cc_traces_weka_with_subagents_060226 (no 256k cap) - Increase lmcache L1 size to full TOTAL_CPU_DRAM_GB (was divided by 8/TP) - Add kimik2.5_fp4_mi355x_org.sh preserving prior config for reference - Rename amd-master config entry to kimik2.5-fp4-mi355x-vllm-agentic-lmcache-longISLlargetDRAM - Revert minimaxm2.5_fp4_mi355x.sh back to 256k-capped trace Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rget -> large) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0607cc7. Configure here.
…t, rename lmcache entry Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Summary
minimaxm2.5-fp4-mi355x-vllm-agentic-lmcacheandkimik2.5-fp4-mi355x-vllm-agentic-lmcacheentries inamd-master.yamlminimaxm2.5_fp4_mi355x.shagentic benchmark script with LMCache supportkimik2.5_fp4_mi355x.sh: simplify env vars, build LMCache from source (ROCm HIP), tuneLMCACHE_L1_SIZE_GB/TTL/chunk sizeqwen3.5_fp8_mi355x.sh: add HiCache offloading support, add 256k trace corpus cap viaWEKA_LOADER_OVERRIDELMCACHE_CHUNK_SIZEdefault to 32 for MiniMax agentic script🤖 Generated with Claude Code
Note
Medium Risk
Large, experimental benchmark-only changes (runtime LMCache git builds, removed ROCm patches, hardcoded DRAM/TODOs) can make sweeps flaky or non-reproducible until tuned, but no production serving paths are touched.
Overview
Expands MI355X agentic-coding coverage in
amd-master.yamlwith new matrix targets that compare GPU-only vs HiCache (SGLang) or LMCache (vLLM) KV offload for Qwen3.5 FP4, GLM5.1 FP4, Kimi K2.5 FP4, and MiniMax M2.5 FP4/FP8—including a Kimi LMCache variant pinned to a 1500 GB DRAM experiment. The existing Qwen3.5 FP8 HiCache target is retuned (new SGLang image, TP=4, wider concurrency grid).Agentic launch scripts are reworked to match: SGLang paths gain
none/hicacheoffload wiring, larger host DRAM budgets (~3 TB), 060226 (256k-capped) trace overrides, and server-flag tweaks; vLLM paths drop the prior ROCm LMCache monkey-patches in favor of cloning and HIP-building LMCache at job time, with retuned L1 pool sizes, 7200s read TTL, and chunk size 32 on MiniMax. Kimi’s script is slimmed to that model; MiniMax FP4 gets a dedicated script;kimik2.5_fp4_mi355x_org.shpreserves an alternate Kimi LMCache sizing/trace setup. GLM5.1’s script is extended for HiCache while keeping GLM-specific SGLang flags.Slurm launcher excludes bad node
mia1-p01-g37alongside existing MI355X blocklist entries.Reviewed by Cursor Bugbot for commit 244de16. Bugbot is set up for automated code reviews on this repo. Configure here.