Fix: Manual CORS header injection and detailed logging in BinaryMiddleware for cross-origin requests #2223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eware for cross-origin requests - Ensures CORS headers are injected for binaryhandler.ashx requests - Adds detailed request and CORS policy logging for easier debugging - Retains logs for cross-project testing (pending user decision to remove) Refs: React frontend CORS issues, browser cache troubleshooting, SnCorsPolicyProvider integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch introduces a targeted fix for cross-origin requests to the binaryhandler.ashx endpoint in SenseNet. It ensures that CORS headers are manually injected in the BinaryMiddleware for GET requests, allowing React and other frontends to fetch images and files from the backend without CORS errors.
Key changes:
This fix resolves issues where browser cache or pipeline branching prevented proper CORS header delivery, and enables successful cross-origin file access from modern frontends.