Elevenlabs not saving#107
Merged
Merged
Conversation
| initial_db_path = self.output_dir / "initial_scenario_db.json" | ||
| final_db_path = self.output_dir / "final_scenario_db.json" | ||
|
|
||
| if not initial_db_path.exists(): |
Collaborator
There was a problem hiding this comment.
Do we need these explicit checks? open() will already raise the same exception
Collaborator
Author
There was a problem hiding this comment.
hm, yeah it will raise but not have as much detail. i'm ok with it either way. This isn't new code, just refactored, but I can still remove it to clean up a bit
| """Stop the server, save outputs.""" | ||
| """Stop the server (framework-specific teardown). | ||
|
|
||
| Note: save_outputs() is called by the base class stop() after _shutdown() |
Collaborator
There was a problem hiding this comment.
not sure if this comment is needed (the 'Note:...'). It makes sense looking at the commit (where we see the line being removed) but not as much in the code itself
raghavm243512
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.