Skip to content

Add checkout kit web component ck_version query param#120

Merged
westeezy merged 1 commit into
mainfrom
05-14-add_checkout_kit_web_component_query_params
May 15, 2026
Merged

Add checkout kit web component ck_version query param#120
westeezy merged 1 commit into
mainfrom
05-14-add_checkout_kit_web_component_query_params

Conversation

@kev-mao
Copy link
Copy Markdown
Contributor

@kev-mao kev-mao commented May 14, 2026

What changes are you making?

Appends ck_versionquery parameter to checkout URLs when opening a popup or rendering the overlay link.


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@kev-mao kev-mao marked this pull request as ready for review May 14, 2026 21:11
@kev-mao kev-mao requested a review from a team as a code owner May 14, 2026 21:11
This was referenced May 14, 2026
Copy link
Copy Markdown
Contributor Author

kev-mao commented May 14, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kev-mao kev-mao mentioned this pull request May 14, 2026
11 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 88%
88.74% (481/542) 79.57% (113/142) 89.47% (51/57)

@westeezy westeezy changed the base branch from port-web-component-over to graphite-base/120 May 14, 2026 21:59
@kev-mao kev-mao force-pushed the 05-14-add_checkout_kit_web_component_query_params branch from dc6491b to daefabc Compare May 14, 2026 22:02
@kev-mao kev-mao changed the base branch from graphite-base/120 to port-web-component-over May 14, 2026 22:02
@kev-mao kev-mao changed the title Add checkout kit web component query params Add checkout kit web component ck_version query param May 14, 2026
Comment thread platforms/web/src/checkout.ts Outdated
@westeezy westeezy changed the base branch from port-web-component-over to graphite-base/120 May 14, 2026 22:16
@kev-mao kev-mao force-pushed the graphite-base/120 branch from cdcfef8 to dfd20f4 Compare May 14, 2026 22:18
@kev-mao kev-mao force-pushed the 05-14-add_checkout_kit_web_component_query_params branch from daefabc to 16f08ac Compare May 14, 2026 22:18
@kev-mao kev-mao changed the base branch from graphite-base/120 to port-web-component-over May 14, 2026 22:18
@westeezy westeezy changed the base branch from port-web-component-over to graphite-base/120 May 14, 2026 23:48
@westeezy westeezy force-pushed the graphite-base/120 branch from dfd20f4 to 02f306f Compare May 15, 2026 00:33
@westeezy westeezy force-pushed the 05-14-add_checkout_kit_web_component_query_params branch from 16f08ac to 9abc35f Compare May 15, 2026 00:33
@westeezy westeezy changed the base branch from graphite-base/120 to main May 15, 2026 00:33
Copy link
Copy Markdown
Contributor

@westeezy westeezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ty

export const DEFAULT_POPUP_WIDTH = 600;
export const DEFAULT_POPUP_HEIGHT = 600;
export const EMBED_PROTOCOL_VERSION = "2026-04-08";
export const CK_VERSION = "4.0.0";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider reading this from package.json in the future.

@westeezy westeezy merged commit a45cd66 into main May 15, 2026
31 of 33 checks passed
@westeezy westeezy deleted the 05-14-add_checkout_kit_web_component_query_params branch May 15, 2026 00:34
@markmur markmur added the #gsd:50662 Rebase Checkout Kit on UCP label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants