feat: add /skills#34
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
Conversation
|
|
||
| const shopifyCheckout = useShopifyCheckoutSheet(); | ||
|
|
||
| const checkoutClient = createCheckoutProtocolClient() |
Contributor
Author
There was a problem hiding this comment.
this is currently pseudocode filler - we havent written out the design for the react-native but i expect it to be mroe like new CheckoutProtocol.Client().on
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-08-featadd/skills
branch
from
4055372 to
e6464fd
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-08-featreadme/skillsaddskillsdirandrefreshreadme
branch
from
d6340a0 to
c9dc00e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-08-featadd/skills
branch
2 times, most recently
from
2bd797e to
92f5c99
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-08-featreadme/skillsaddskillsdirandrefreshreadme
branch
from
c9dc00e to
731d669
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-08-featadd/skills
branch
from
92f5c99 to
d898a59
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-08-featadd/skills
branch
from
d898a59 to
df31822
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-08-featreadme/skillsaddskillsdirandrefreshreadme
branch
2 times, most recently
from
9c35a97 to
da4cbcd
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-08-featadd/skills
branch
from
df31822 to
b64cbda
Compare
kieran-osgood-shopify
changed the base branch from
kieran-osgood/05-08-featreadme/skillsaddskillsdirandrefreshreadme
to
graphite-base/34
kieran-osgood-shopify
force-pushed
the
graphite-base/34
branch
from
9c35a97 to
e94799c
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-08-featadd/skills
branch
from
b64cbda to
6b08be6
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/05-08-featadd/skills
branch
from
6b08be6 to
97b3304
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
I'm shipping this in two stacks as the skills needs to wait until we have defined the API design of the react-native repo - once thats done we can update all of the code samples below
How to test
Before you merge
Important
swift/README.mdand/orandroid/README.md)Releasing a new Swift version?
swift/ShopifyCheckoutKit.podspecswift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftswift/CHANGELOG.mdswift/README.md(major version only)Releasing a new Android version?
versionNameinandroid/lib/build.gradleandroid/CHANGELOG.mdandroid/README.mdTip
See the Contributing documentation for the full release process per platform.