Align workspace dev commands in root dev.yml#69
Open
kyle-schellen wants to merge 1 commit into
Open
Conversation
kyle-schellen
changed the base branch from
main
to
05-11-move_react_native_dev_commands_under_root_dev.yml
kyle-schellen
changed the title
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
from
7077869 to
c4188d2
Compare
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
from
c4188d2 to
cf8541b
Compare
kyle-schellen
force-pushed
the
05-11-move_react_native_dev_commands_under_root_dev.yml
branch
from
f9cf466 to
79b74a1
Compare
React Native — Coverage Report
|
kyle-schellen
force-pushed
the
05-11-move_react_native_dev_commands_under_root_dev.yml
branch
from
79b74a1 to
fa6fa57
Compare
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
2 times, most recently
from
cf27458 to
ea11c12
Compare
kyle-schellen
force-pushed
the
05-11-move_react_native_dev_commands_under_root_dev.yml
branch
from
fa6fa57 to
87da5c4
Compare
kyle-schellen
commented
May 12, 2026
| supported_exts = %w[.swift .h .mm .java .js .ts .tsx] | ||
|
|
||
| Find.find(dir) do |path| | ||
| next if path.include?('/build/generated/') |
Author
There was a problem hiding this comment.
This keeps the RN license check focused on source-controlled files. Generated Android build output can exist locally after builds/codegen and does not reliably include our license header, which made dev check depend on local build state
kyle-schellen
commented
May 12, 2026
| @@ -292,7 +292,7 @@ class RCTShopifyCheckoutSheetKit: RCTEventEmitter, CheckoutDelegate { | |||
| return NSNumber(value: available) | |||
| } | |||
|
|
|||
| @objc func initiateGeolocationRequest(_ allow: Bool) { | |||
| @objc func initiateGeolocationRequest(_: Bool) { | |||
Author
There was a problem hiding this comment.
Root dev check surfaced an existing SwiftFormat issue. The parameter is intentionally unused, so _ is the correct shape here.
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
from
ea11c12 to
f46976e
Compare
kyle-schellen
force-pushed
the
05-11-move_react_native_dev_commands_under_root_dev.yml
branch
from
87da5c4 to
3604836
Compare
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
2 times, most recently
from
2b1514e to
9514af8
Compare
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
from
9514af8 to
de4dcf6
Compare
|
|
||
| ## Dev workflow | ||
|
|
||
| Run `dev` commands from the repo root. Use `dev up` before running commands when |
Contributor
There was a problem hiding this comment.
Not sure if you've had success with this locally but I think telling it to use shadoenv and where to get dev from helped with certain ai sandboxing
All commands require `shadowenv exec --` prefix.
shadowenv exec --dir DIR -- /opt/dev/bin/dev up
shadowenv exec --dir DIR -- /opt/dev/bin/dev test [ARGS]
| - [Privacy compliance](https://shopify.dev/docs/storefronts/mobile/checkout-kit/privacy-compliance) - pass GDPR, CCPA, and ATT consent through to Shopify. | ||
| - [Accelerated checkouts](https://shopify.dev/docs/storefronts/mobile/checkout-kit/accelerated-checkouts?extension=react-native) - Shop Pay and Apple Pay buttons for one-tap purchase on product and cart pages. | ||
|
|
||
| ## Development |
Contributor
There was a problem hiding this comment.
I think we can move this section into the CONTRIBUTING.md to help keep the readme slim
| run: cd platforms/swift && ./Scripts/lint fix | ||
| clean: | ||
| desc: Clean Swift package build artifacts | ||
| run: cd platforms/swift && ./Scripts/xcode_run clean ShopifyCheckoutKit-Package |
Contributor
There was a problem hiding this comment.
I think it'd make sense to add in a clean on the sample app and the ShopifyAcceleratedCheckouts package here too
| run: | | ||
| echo "Usage: dev swift build {packages|samples}" | ||
| desc: Build the Swift package | ||
| run: cd platforms/swift && ./Scripts/xcode_run build ShopifyCheckoutKit-Package |
Contributor
There was a problem hiding this comment.
similar to above, I think we should build the main package (which you're doing), the AcceleratedCheckouts package, as well as the sample app (sample app acts as an integration compilation check)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #908.
What changes
Adds repo-wide commands (
build,test,lint,format,check) to the rootdev.yml. Makesformatcanonical withfixaliased. AddsAGENTS.mdguidance.Audit follow-ups in the same diff:
dev android checkdelegates tolint+check license-headers(was inline gradle)dev android apiexits 1 on missing subcommanddev swift build packagesdev react-native formatdesc clarifies Swift bridge only scopeHow to test
From the repo root:
dev build,dev test,dev lint,dev format,dev checkrun across all platformsdev android clean,dev swift clean,dev react-native cleanclean build artifactsdev protocol build,dev protocol test,dev protocol checkdev <platform> formatworks;fixalias preserveddev android apiwith no subcommand prints usage and exits 1dev android checkruns license-headers + lint via delegationBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
platforms/swift/ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.