QA to E2E: app basic flow (no extensions)

[phyllis-sy-wu]

WHY are these changes introduced?

To replace manual CLI QA with automated end-to-end tests that validate the complete app development workflow in a real environment.

This is part of Vault project #gsd:49408 to automate CLI QA coverage.

WHAT is this pull request doing?

Adds tests/app-basic.spec.ts: a full lifecycle e2e test covering 9 steps:

Step	Command	Description
1	app init	React Router, JS, npm
2	app dev	Waits for "Ready" with keyboard shortcuts enabled (CI='')
3	app execute	Runs a GraphQL query against the live dev server
4	q key	Sends q keystroke to terminate the dev server
5	app dev clean	Tears down the dev preview
6	app deploy	Deploys with a unique version tag
7	app versions list --json	Asserts the version tag appears
8	app config link --client-id <secondary>	Pre-creates a minimal shopify.app.secondary.toml stub (client_id = "...") before spawning, so getTomls() finds the secondary client ID and loadConfigurationFileName returns the filename immediately without triggering the interactive "Configuration file name:" prompt
9	app deploy --config secondary	Deploys to the secondary app using the linked config file, with SHOPIFY_FLAG_CLIENT_ID unset to avoid the --config/--client-id mutual exclusion enforced by oclif

Supporting changes:

• setup/cli.ts: adds extendEnv: false to exec and execCreateApp so the test's explicit processEnv is the complete environment — no leakage from the parent shell
• setup/auth.ts: logs "Authenticating automatically" for both the browser OAuth path and the partners-token path (was missing from the token path)
• package.json: adds @shopify/cli-kit: 3.92.0 as a devDependency (required for the joinPath import, pinned to match all other packages per the repo-health version sync check)

Divergence from the manual flow

In the manual flow:

1. app init creates a new app (you pick org, name a new app)
2. app dev links to that new app
3. app deploy deploys to that new app
4. At the end you clean up the app from the Partners dashboard

In the e2e test:

1. app init scaffolds the local directory but links to a pre-existing app via SHOPIFY_FLAG_CLIENT_ID
2. Everything else runs against that pre-existing app

Why the test does it this way:

• Creating a new Partners app in CI requires interactive prompts (pick org, name the app) that are hard to automate reliably
• Using a pre-existing app with a known client_id skips all that interactivity
• No cleanup needed — no risk of leaving orphaned apps on the platform

The tradeoff:

• The test doesn't cover the "create new app" path of app init
• It does cover everything else faithfully (dev, execute, deploy, versions, config link, secondary deploy)

How to test your changes?

Running the test

• Requires .env with SHOPIFY_FLAG_CLIENT_ID (primary test app), E2E_STORE_FQDN, E2E_SECONDARY_CLIENT_ID (secondary test app).
• Primary test needs access scope: write_product

DEBUG=1 pnpm --filter e2e exec playwright test app-basic

Verifying each step catches failures

1. Break — edit source, then

   pnpm nx build app --skip-nx-cache && pnpm nx build cli --skip-nx-cache

2. Run test — confirm it fails with ‼️ Step N - <command> failed
3. Fix — revert source, then

   pnpm nx build app --skip-nx-cache && pnpm nx build cli --skip-nx-cache

4. Run test — confirm it passes again

Step	Command	Source
1	app init	init.ts
2	app dev	dev.ts
3	app execute	execute.ts
4	q key	DevSessionUI
5	app dev clean	dev-clean.ts
6	shopify app deploy --version v1	deploy.ts, version-name.ts
7	app versions list --json	versions-list.ts
8	app config link --client-id <secondary>	link.ts
9	app deploy --config secondary	deploy.ts

Measuring impact

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

Screenshots

Expand to see comparison of manual vs. automated flow

Step 1: shopify app init

Flow	Process/Actions
Manual
Automated

Step 2: shopify app dev

Flow	Process/Actions
Manual
Automated

Step 3: shopify app execute

Flow	Process/Actions
Manual
Automated

Step 4: Quit - q

Flow	Process/Actions
Manual
Automated

Step 5: shopify app dev clean

Flow	Process/Actions
Manual
Automated

Step 6: shopify app deploy --version v1

Flow	Process/Actions
Manual
Automated

Step 7: shopify app versions list --json

Flow	Process/Actions
Manual	First version is from manual flow, second version is from automated flow:
Automated

Step 8: app config link

Flow	Process/Actions
Manual
Automated

Step 9: shopify app deploy

Flow	Process/Actions
Manual
Automated

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟢	Statements	82.2%	14981/18225
🟡	Branches	74.59%	7408/9932
🟢	Functions	81.22%	3780/4654
🟢	Lines	82.61%	14168/17151

Test suite run success

3924 tests passing in 1510 suites.

Report generated by 🧪jest coverage report action from eaad57b

[phyllis-sy-wu]

• QA to E2E: app basic flow (no extensions) #7047 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

Adds a new Playwright end-to-end test in packages/e2e to automate the “basic app lifecycle” QA flow (init → dev → execute → quit → dev clean → deploy → versions → config link → deploy via secondary config), plus supporting fixture and dependency updates to make the flow reliable in CI.

Changes:

• Introduces app-basic.spec.ts to cover the full app workflow including secondary config link + deploy.
• Updates the e2e CLI fixture to avoid inheriting the parent shell environment (extendEnv: false).
• Adds a @shopify/cli-kit devDependency to packages/e2e to support joinPath usage.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pnpm-lock.yaml	Lockfile updates for the new @shopify/cli-kit devDependency and resulting dependency graph changes.
packages/e2e/tests/app-basic.spec.ts	New end-to-end “basic flow” test including config link + secondary deploy.
packages/e2e/setup/cli.ts	Adjusts execa options to prevent env leakage by disabling env extension.
packages/e2e/setup/auth.ts	Adds a console log indicating automatic authentication.
packages/e2e/setup/app.ts	Avoids parsing scaffold output when create-app exits non-zero (returns early).
packages/e2e/package.json	Adds @shopify/cli-kit devDependency needed by the new test.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[dmerand]

I'm aligned with the overall approach. Agent review found a few bugs worth checking.

---

Review assisted by pair-review