Draft
Conversation
Contributor
Coverage report
Test suite run success3910 tests passing in 1502 suites. Report generated by 🧪jest coverage report action from d519470 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To replace manual CLI QA with automated end-to-end tests that validate the complete app development workflow in a real environment. This is a part of Vault project #gsd:49408.
WHAT is this pull request doing?
Adds
packages/e2e/tests/hydrogen.spec.ts— an e2e test for the Hydrogen basic flow using mock.shop:hydrogen init --install-deps --mock-shop— scaffolds the storefront and installs dependencies via npm (forced vianpm_config_user_agentto avoid pnpm being detected from the monorepo environment). Asserts on "Storefront setup complete!"hydrogen initnormally requires selecting a connected Shopify store with Hydrogen channel access. The--mock-shopflag bypasses this by routing all Storefront API calls tomock.shop, so no real store or Hydrogen channel is needed.hydrogen build— builds the storefront for productionhydrogen dev— starts the MiniOxygen dev server and makes an HTTP request to verify it returns 200How to test your changes?
Run the e2e test suite to verify the new Hydrogen test passes:
The test should complete successfully, demonstrating that all three Hydrogen CLI commands work as expected.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist