Open
Conversation
Contributor
Coverage report
Test suite run success3910 tests passing in 1502 suites. Report generated by 🧪jest coverage report action from 2ee02ec |
ryancbahan
approved these changes
Mar 20, 2026
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
After #7029 the unit tests are failing sometimes with SIGABRT / ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL in MacOS.
Example: https://github.com/Shopify/cli/actions/runs/23306039213/job/67781905116
WHAT is this pull request doing?
forks→threadspool switch causes intermittentSIGABRTcrashes on macOS CI runners. This is a known vitest issue where native modules (like@parcel/watcher,esbuild) aren't thread-safe and crash when loaded viaworker_threads. The vitest docs recommend switching toforkspool as the fix.--pool forksfor macOS CI jobs only; Linux and Windows keepthreadsfor the ~12s speedupHow to test your changes?
CI
Measuring impact
How do we know this change was effective? Please choose one:
Checklist