Conversation
|
/snapit |
Coverage report
Test suite run success3924 tests passing in 1508 suites. Report generated by 🧪jest coverage report action from 0d99111 |
This comment was marked as outdated.
This comment was marked as outdated.
c40b471 to
2b77fb7
Compare
2b77fb7 to
a52b36d
Compare
|
/snapit |
This comment was marked as outdated.
This comment was marked as outdated.
dbbac0b to
0d99111
Compare
|
/snapit |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/constants.d.ts@@ -8,6 +8,7 @@ export declare const environmentVariables: {
env: string;
firstPartyDev: string;
noAnalytics: string;
+ cliToken: string;
partnersToken: string;
runAsUser: string;
serviceEnv: string;
packages/cli-kit/dist/public/node/environment.d.ts@@ -10,17 +10,12 @@
*/
export declare function getEnvironmentVariables(): NodeJS.ProcessEnv;
/**
- * Returns the value of the SHOPIFY_CLI_PARTNERS_TOKEN environment variable.
+ * Returns the value of the SHOPIFY_CLI_TOKEN environment variable,
+ * falling back to the deprecated SHOPIFY_CLI_PARTNERS_TOKEN.
*
- * @returns Current process environment variables.
- */
-export declare function getPartnersToken(): string | undefined;
-/**
- * Check if the current proccess is running using the partners token.
- *
- * @returns True if the current proccess is running using the partners token.
+ * @returns The CLI token value, or undefined if neither env var is set.
*/
-export declare function usePartnersToken(): boolean;
+export declare function getCliToken(): string | undefined;
/**
* Returns the value of the organization id from the environment variables.
*
packages/cli-kit/dist/private/node/session/exchange.d.ts@@ -25,7 +25,7 @@ export declare function exchangeAccessForApplicationTokens(identityToken: Identi
*/
export declare function refreshAccessToken(currentToken: IdentityToken): Promise<IdentityToken>;
/**
- * Given a custom CLI token passed as ENV variable, request a valid Partners API token
+ * Given a custom CLI token passed as ENV variable, request a valid Partners API token.
* This token does not accept extra scopes, just the cli one.
* @param token - The CLI token passed as ENV variable
* @returns An instance with the application access tokens.
@@ -35,7 +35,7 @@ export declare function exchangeCustomPartnerToken(token: string): Promise<{
userId: string;
}>;
/**
- * Given a custom CLI token passed as ENV variable, request a valid App Management API token
+ * Given a custom CLI token passed as ENV variable, request a valid App Management API token.
* @param token - The CLI token passed as ENV variable
* @returns An instance with the application access tokens.
*/
@@ -44,7 +44,7 @@ export declare function exchangeCliTokenForAppManagementAccessToken(token: strin
userId: string;
}>;
/**
- * Given a custom CLI token passed as ENV variable, request a valid Business Platform API token
+ * Given a custom CLI token passed as ENV variable, request a valid Business Platform API token.
* @param token - The CLI token passed as ENV variable
* @returns An instance with the application access tokens.
*/
|
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260320135524Caution After installing, validate the version by running |
WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/22293
WHAT is this pull request doing?
SHOPIFY_CLI_TOKENenvironment variable with the same behavior asSHOPIFY_CLI_PARTNERS_TOKENHow to test your changes?
npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260320135524SHOPIFY_CLI_TOKEN=xxx shopify app deploySHOPIFY_CLI_PARTNERS_TOKEN=xxx shopify app deployMeasuring impact
How do we know this change was effective? Please choose one:
Checklist