Skip to content

Preserve structured app validation issues internally#7066

Draft
dmerand wants to merge 1 commit intodlm-app-validate-jsonfrom
dlm-app-validate-errors
Draft

Preserve structured app validation issues internally#7066
dmerand wants to merge 1 commit intodlm-app-validate-jsonfrom
dlm-app-validate-errors

Conversation

@dmerand
Copy link
Contributor

@dmerand dmerand commented Mar 20, 2026

What

Preserve structured app validation issues internally during app loading.

This keeps the current CLI behavior the same while retaining structured issue metadata alongside the rendered validation messages.

Why

The new app validate --json mode is a useful start, but the validation pipeline still flattens schema issues into strings too early.

To support repair loops and future automation work, the CLI needs to retain structured validation details before deciding how to render them publicly.

How

  • add structured issue parsing alongside the existing human-readable formatter
  • preserve structured issue metadata at the loader/report boundary
  • update AppErrors to retain both rendered messages and structured issues
  • keep current text output and existing public behavior unchanged

Testing

To test manually:

  1. Run shopify app validate against invalid app or extension config and confirm the visible CLI output is unchanged.
  2. Review the focused loader and parsing test coverage for schema errors, union errors, and repeated error writes for the same file path.

Copy link
Contributor Author

dmerand commented Mar 20, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dmerand dmerand mentioned this pull request Mar 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 82.22% 14967/18204
🟡 Branches 74.69% 7417/9931
🟢 Functions 81.29% 3781/4651
🟢 Lines 82.61% 14149/17128

Test suite run success

3924 tests passing in 1506 suites.

Report generated by 🧪jest coverage report action from 3c313f8

@dmerand dmerand force-pushed the dlm-app-validate-json branch from 59c4766 to efd8c3d Compare March 20, 2026 18:24
@dmerand dmerand force-pushed the dlm-app-validate-errors branch 2 times, most recently from b6ee50f to 113bc0e Compare March 20, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant