Only show active stores for app dev#7500
Conversation
github-actions
Bot
added
the
no-changelog
There was a problem hiding this comment.
Pull request overview
Filters the shopify app dev store-selection list to only include active app development stores by tightening the Business Platform query used to fetch dev stores.
Changes:
- Update
ListAppDevStoresGraphQL query to requireSTORE_STATUS=ACTIVEin addition toSTORE_TYPE=app_development. - Regenerate the
list_app_dev_storesgenerated artifact to match the updated query shape (filters list). - Add unit tests covering the request shape (including the embedded filter AST) and empty-result behavior for
devStoresForOrg.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts | Uses a small helper for storeByDomain filters; leaves status filtering scoped to ListAppDevStores as described. |
| packages/app/src/cli/utilities/developer-platform-client/app-management-client.test.ts | Adds coverage for devStoresForOrg request shape (including STORE_STATUS=ACTIVE) and empty results. |
| packages/app/src/cli/api/graphql/business-platform-organizations/queries/list_app_dev_stores.graphql | Adds STORE_STATUS=ACTIVE filter to the dev-stores list query. |
| packages/app/src/cli/api/graphql/business-platform-organizations/generated/list_app_dev_stores.ts | Regenerated query artifact reflecting filters as a list with both required filters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/snapit |
|
🫰✨ Thanks @dmerand! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260508150036Caution After installing, validate the version by running |
| return {...err, details} | ||
| } | ||
|
|
||
| // Keep explicit domain lookup broader than ListAppDevStores for now. |
There was a problem hiding this comment.
This is used when you manually pass a store instead of selecting it from the list. Do we really want to allow deleted stores there? Is there any use case in the CLI where we do want to allow them?
I think I prefer to add the filter everywhere now.
There was a problem hiding this comment.
I wanted to limit blast radius to the stated issue. If you agree, I'll follow up with adding the filter everywhere.
What
Filter
app devstore selection to active app development stores in Business Platform.This updates the dev-store list query to require
STORE_STATUS=ACTIVE, regenerates the query artifact, and adds coverage for the request shape and empty-result behavior.Why
app dev --resetcan surface deleted or inactive app dev stores because the CLI only filters bySTORE_TYPE=app_developmenttoday.That makes it possible to reselect stores that the CLI should no longer treat as valid for app dev flows.
How
Add
STORE_STATUS=ACTIVEtoListAppDevStores, matching the filter pattern already used by Dev Dashboard for app dev stores.Keep explicit domain lookup (
storeByDomain) unchanged in this PR because that path is shared by mixed store-type flows. Leave a small helper and breadcrumb there so a narrower follow-up can add the same status filter forAPP_DEVELOPMENTlookups with dedicated coverage.Testing
Run
shopify app devfor an app linked to an organization that has inactive or deleted app dev stores and confirm the flow only lists active app dev stores.Here's an after/before: