[Refactor] Extract shared execution environment logic in system.ts#7515
[Refactor] Extract shared execution environment logic in system.ts#7515gonzaloriestra wants to merge 1 commit into
Conversation
Extract shared environment and CWD setup logic into a new private helper function `getExecutionEnvironment` in `packages/cli-kit/src/public/node/system.ts`. This refactor reduces duplication in `captureCommandWithExitCode`, `execCommand`, and `buildExec`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
packages/cli-kit/src/public/node/system.tsfile contained duplicated logic for preparing the execution environment (settingFORCE_COLORand determining thecwd) across three different functions:captureCommandWithExitCode,execCommand, andbuildExec.WHAT is this pull request doing?
This PR extracts the shared environment and CWD setup logic into a new private helper function
getExecutionEnvironment. It then refactorscaptureCommandWithExitCode,execCommand, andbuildExecto use this helper, improving maintainability and reducing code duplication.How to test your changes?
Run the unit tests for
system.ts:pnpm vitest run packages/cli-kit/src/public/node/system.test.tsChecklist
pnpm changeset addDuplicate check
I performed a duplicate check using
git log --grep="\[Refactor\]" --grep="Jules" --onelineasghis not available. No previous PRs were found targeting this specific duplication insystem.ts.PR created automatically by Jules for task 9574303689973063028 started by @gonzaloriestra