Skip to content

Drop analyticsNameOverride on app generate extension#7536

Open
alfonso-noriega wants to merge 1 commit into
mainfrom
fonso/drop-generate-extension-analytics-override
Open

Drop analyticsNameOverride on app generate extension#7536
alfonso-noriega wants to merge 1 commit into
mainfrom
fonso/drop-generate-extension-analytics-override

Conversation

@alfonso-noriega
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Addresses this metric thread on #7524. The app generate extension command currently overrides its analytics name to app scaffold extension — a holdover from before the rename. Now that the deprecated scaffold extension command itself is being removed in the parent PR (#7525), this override is misleading: analytics events from app generate extension should report the actual command name users run.

Stacked on top of #7525.

WHAT is this pull request doing?

  • Removes the analyticsNameOverride() method from AppGenerateExtension.
  • Analytics events for shopify app generate extension will now flow through with the natural command name (app generate extension) instead of the legacy app scaffold extension.

How to test your changes?

  1. Run pnpm shopify app generate extension --template ... in dev mode.
  2. Confirm the analytics event reports app generate extension (e.g. via debug analytics output) — not app scaffold extension.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact — this PR is the analytics change
  • No user-visible behaviour change → no changeset

The override was forcing analytics events to report this command as
`app scaffold extension`, which predates the rename to `app generate extension`.
With the deprecated `scaffold extension` command being removed in the parent PR,
this override no longer makes sense \u2014 analytics should reflect the actual
command users run.
@alfonso-noriega alfonso-noriega requested a review from a team as a code owner May 12, 2026 16:51
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Potential Breaking Changes Detected

This PR contains changes that may break the existing contract.

@shopify/dev_experience — this PR contains breaking changes that require coordination for the next major release. This check will remain failed until a member of the team approves the workflow run.

💬 Head to #help-dev-platform to discuss timing and plan the release.

📦 Major Version Changesets

The following changesets request a major version bump:

Changeset Package
remove-app-deploy-force-flag.md '@shopify/app': major
remove-app-generate-extension-type-flag.md '@shopify/app': major
remove-app-generate-schema-command.md '@shopify/app': major
remove-app-release-force-flag.md '@shopify/app': major
remove-app-scaffold-extension-command.md '@shopify/app': major
remove-webhook-trigger-shared-secret-flag.md '@shopify/app': major
thin-webs-notice.md '@shopify/plugin-did-you-mean': major
thin-webs-notice.md '@shopify/plugin-cloudflare': major
thin-webs-notice.md '@shopify/create-app': major
thin-webs-notice.md '@shopify/cli-kit': major
thin-webs-notice.md '@shopify/store': major
thin-webs-notice.md '@shopify/theme': major
thin-webs-notice.md '@shopify/app': major
thin-webs-notice.md '@shopify/cli': major
thin-webs-notice.md '@shopify/e2e': major

@alfonso-noriega alfonso-noriega deployed to breaking-change-approval May 12, 2026 16:53 — with GitHub Actions Active
@github-actions
Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -8,7 +8,6 @@ export declare const environmentVariables: {
     env: string;
     firstPartyDev: string;
     noAnalytics: string;
-    optOutInstrumentation: string;
     appAutomationToken: string;
     partnersToken: string;
     runAsUser: string;
packages/cli-kit/dist/public/node/context/local.d.ts
@@ -53,7 +53,7 @@ export declare function isUnitTest(env?: NodeJS.ProcessEnv): boolean;
  * Returns true if reporting analytics is enabled.
  *
  * @param env - The environment variables from the environment of the current process.
- * @returns True unless SHOPIFY_CLI_NO_ANALYTICS or OPT_OUT_INSTRUMENTATION is truthy, or debug mode is enabled.
+ * @returns True unless SHOPIFY_CLI_NO_ANALYTICS is truthy or debug mode is enabled.
  */
 export declare function analyticsDisabled(env?: NodeJS.ProcessEnv): boolean;
 /**

Base automatically changed from 06-remove-app-scaffold-extension-command to main May 12, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant