Drop analyticsNameOverride on app generate extension#7536
Open
alfonso-noriega wants to merge 1 commit into
Open
Drop analyticsNameOverride on app generate extension#7536alfonso-noriega wants to merge 1 commit into
app generate extension#7536alfonso-noriega wants to merge 1 commit into
Conversation
The override was forcing analytics events to report this command as `app scaffold extension`, which predates the rename to `app generate extension`. With the deprecated `scaffold extension` command being removed in the parent PR, this override no longer makes sense \u2014 analytics should reflect the actual command users run.
Contributor
|
| Changeset | Package |
|---|---|
remove-app-deploy-force-flag.md |
'@shopify/app': major |
remove-app-generate-extension-type-flag.md |
'@shopify/app': major |
remove-app-generate-schema-command.md |
'@shopify/app': major |
remove-app-release-force-flag.md |
'@shopify/app': major |
remove-app-scaffold-extension-command.md |
'@shopify/app': major |
remove-webhook-trigger-shared-secret-flag.md |
'@shopify/app': major |
thin-webs-notice.md |
'@shopify/plugin-did-you-mean': major |
thin-webs-notice.md |
'@shopify/plugin-cloudflare': major |
thin-webs-notice.md |
'@shopify/create-app': major |
thin-webs-notice.md |
'@shopify/cli-kit': major |
thin-webs-notice.md |
'@shopify/store': major |
thin-webs-notice.md |
'@shopify/theme': major |
thin-webs-notice.md |
'@shopify/app': major |
thin-webs-notice.md |
'@shopify/cli': major |
thin-webs-notice.md |
'@shopify/e2e': major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/constants.d.ts@@ -8,7 +8,6 @@ export declare const environmentVariables: {
env: string;
firstPartyDev: string;
noAnalytics: string;
- optOutInstrumentation: string;
appAutomationToken: string;
partnersToken: string;
runAsUser: string;
packages/cli-kit/dist/public/node/context/local.d.ts@@ -53,7 +53,7 @@ export declare function isUnitTest(env?: NodeJS.ProcessEnv): boolean;
* Returns true if reporting analytics is enabled.
*
* @param env - The environment variables from the environment of the current process.
- * @returns True unless SHOPIFY_CLI_NO_ANALYTICS or OPT_OUT_INSTRUMENTATION is truthy, or debug mode is enabled.
+ * @returns True unless SHOPIFY_CLI_NO_ANALYTICS is truthy or debug mode is enabled.
*/
export declare function analyticsDisabled(env?: NodeJS.ProcessEnv): boolean;
/**
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Addresses this metric thread on #7524. The
app generate extensioncommand currently overrides its analytics name toapp scaffold extension— a holdover from before the rename. Now that the deprecatedscaffold extensioncommand itself is being removed in the parent PR (#7525), this override is misleading: analytics events fromapp generate extensionshould report the actual command name users run.Stacked on top of #7525.
WHAT is this pull request doing?
analyticsNameOverride()method fromAppGenerateExtension.shopify app generate extensionwill now flow through with the natural command name (app generate extension) instead of the legacyapp scaffold extension.How to test your changes?
pnpm shopify app generate extension --template ...in dev mode.app generate extension(e.g. via debug analytics output) — notapp scaffold extension.Checklist