[Tests] Remove filesystem mocks in copy-by-pattern.test.ts#7538
[Tests] Remove filesystem mocks in copy-by-pattern.test.ts#7538gonzaloriestra wants to merge 1 commit into
Conversation
Refactor copy-by-pattern.test.ts to use real filesystem operations in temporary directories instead of vi.mock('@shopify/cli-kit/node/fs'). This makes the tests more robust and behavior-focused.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The test suite for
copyByPatternwas using extensive filesystem mocking viavi.mock('@shopify/cli-kit/node/fs'). This leads to brittle tests that assert on implementation details (which internal functions are called) rather than actual behavior (what files are created on disk).WHAT is this pull request doing?
vi.mock('@shopify/cli-kit/node/fs')frompackages/app/src/cli/services/build/steps/include-assets/copy-by-pattern.test.ts.inTemporaryDirectoryand real filesystem operations.fileExistsSyncfor assertions to comply withvitest/prefer-expect-resolveslinting rules.How to test your changes?
Run the unit tests for the affected file:
Duplicate check
I searched for previous PRs with the
Juleslabel and "Tests" in the title usinggit logand available memory.[Tests] Remove filesystem mocks in execute-operation.test.ts: This PR targeted a different service and file.Checklist
pnpm changeset add(N/A for internal test refactor)PR created automatically by Jules for task 220001070802494390 started by @gonzaloriestra