Skip to content

[Tests] Remove filesystem mocks in copy-by-pattern.test.ts#7538

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
tester/remove-fs-mocks-copy-by-pattern-220001070802494390
Draft

[Tests] Remove filesystem mocks in copy-by-pattern.test.ts#7538
gonzaloriestra wants to merge 1 commit into
mainfrom
tester/remove-fs-mocks-copy-by-pattern-220001070802494390

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The test suite for copyByPattern was using extensive filesystem mocking via vi.mock('@shopify/cli-kit/node/fs'). This leads to brittle tests that assert on implementation details (which internal functions are called) rather than actual behavior (what files are created on disk).

WHAT is this pull request doing?

  • Removes vi.mock('@shopify/cli-kit/node/fs') from packages/app/src/cli/services/build/steps/include-assets/copy-by-pattern.test.ts.
  • Refactors all tests to use inTemporaryDirectory and real filesystem operations.
  • Updates assertions to verify the presence and content of files on disk.
  • Uses fileExistsSync for assertions to comply with vitest/prefer-expect-resolves linting rules.

How to test your changes?

Run the unit tests for the affected file:

pnpm --filter @shopify/app vitest run src/cli/services/build/steps/include-assets/copy-by-pattern.test.ts

Duplicate check

I searched for previous PRs with the Jules label and "Tests" in the title using git log and available memory.

  • [Tests] Remove filesystem mocks in execute-operation.test.ts: This PR targeted a different service and file.
  • No other PRs were found targeting this specific subsystem or file.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type and added a changeset with pnpm changeset add (N/A for internal test refactor)

PR created automatically by Jules for task 220001070802494390 started by @gonzaloriestra

Refactor copy-by-pattern.test.ts to use real filesystem operations in temporary directories instead of vi.mock('@shopify/cli-kit/node/fs'). This makes the tests more robust and behavior-focused.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant