Fix Windows auto-upgrade for local CLI installs#7555
Merged
Conversation
`currentProcessIsGlobal()` decides between global and local installs by comparing the project root against `process.argv[1]`. The project root flows through `getProjectDir` -> `findPathUpSync` -> `normalizePath` (pathe), which always returns forward slashes on every platform. `process.argv[1]` is OS-native, so on Windows it arrives backslash-separated and the raw `startsWith` comparison ends up as: binDir: C:\\Users\\me\\proj\\node_modules\\@Shopify\\cli\\bin\\run.js projectDir: C:/Users/me/proj binDir.startsWith(projectDir) => false The local install was misclassified as global, so the postrun hook ran `npm install -g @shopify/cli@latest` after every command on Windows even when @shopify/cli was declared as a project dependency. Switches the comparison to `isSubpath` (pathe.relative under the hood) which tolerates either separator, and bails early if argv[1] is empty so we don't accidentally classify it as 'in any directory'. Adds a regression test that constructs the exact Windows shape (forward- slash projectDir vs. backslash argv[1]) — the existing POSIX-shaped tests happened to agree on slashes when CI runs on Linux, so they didn't catch this. Reported by Nick Wesselman; root cause analysis by River.
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
github-actions
Bot
added
the
no-changelog
isaacroldan
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add