Fix tokenizer to skip closing braces inside quoted strings#2063
Open
knu wants to merge 1 commit intoShopify:mainfrom
Open
Fix tokenizer to skip closing braces inside quoted strings#2063knu wants to merge 1 commit intoShopify:mainfrom
knu wants to merge 1 commit intoShopify:mainfrom
Conversation
The byte-scanning tokenizer does not account for quoted strings when
scanning for `}}` to terminate a variable token. A `}` inside a
quoted filter argument prematurely ends the token, causing a
SyntaxError.
For example, the following valid template fails to parse:
{{ message | replace: "{name}", customer_name }}
This patch makes `next_variable_token` skip over single- and
double-quoted strings so that their contents do not interfere with
`}}` detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The byte-scanning tokenizer does not account for quoted strings when scanning for
}}to terminate a variable token. A}inside a quoted filter argument prematurely ends the token, causing a SyntaxError.For example, the following valid template fails to parse:
This patch makes
next_variable_tokenskip over single- and double-quoted strings so that their contents do not interfere with}}detection.