Provide --update-server command for ruby-lsp exec#3585
Open
vicocamacho wants to merge 2 commits intoShopify:mainfrom
Open
Provide --update-server command for ruby-lsp exec#3585vicocamacho wants to merge 2 commits intoShopify:mainfrom
vicocamacho wants to merge 2 commits intoShopify:mainfrom
Conversation
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Contributor
Author
|
@vinistock would you mind taking a look and verifying that this is doing what the PR is asking? |
Contributor
|
This pull request is being marked as stale because there was no activity in the last 2 months |
Contributor
|
This pull request is being marked as stale because there was no activity in the last 2 months |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3124
This PR adds a
--update-serveroption to theruby-lspcommand to provide users with the ability to easy upgrade the gem's version and automatically use the correct env to perform the upgrade.Implementation
I leveraged the existing
SetupBundlerclass to pull the correct environment configuration and then I use that to run the bundle update command.Automated Tests
I added one automated integration test to verify the execution.
Manual Tests
I have run some manual tests in my local machine.