Skip to content

Conversation

@edwardloveall
Copy link

Motivation

It took me a bit of experimentation to figure out how to configure addonSettings in zed given the mixed cases and lack of examples. So I added an example.

Automated Tests

None. Text change only.

Manual Tests

I verified that this setting does take effect once the LSP is restarted. I rolled back a migration, restarted the server, restarted the LSP the alert showed up. Then I added the config, restarted the server, and saw no alert.

@edwardloveall edwardloveall requested a review from a team as a code owner February 3, 2026 19:53
Code, use the official [Ruby LSP extension](https://marketplace.visualstudio.com/items?itemName=Shopify.ruby-lsp).

{: .note }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not add these newline changes?

"initialization_options": {
"addonSettings": {
"Ruby LSP Rails": {
"enablePendingMigrationsPrompt": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be added to Zed's documentation instead? I find it odd that users need to first visit Zed's doc to see how to setup ruby-lsp, but for addons they need to visit here instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you're saying, but it seems more sustainable to me for the vendor of the config to host that config's documentation. Also, there's a similar note in the Neovim config so I was mimicking that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants