Conversation
Morriar
approved these changes
Mar 24, 2026
vinistock
force-pushed
the
03-18-ensure_that_comments_above_method_decorator_are_considered_documentation
branch
from
e0304d3 to
b138a88
Compare
vinistock
deleted the
03-18-ensure_that_comments_above_method_decorator_are_considered_documentation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not considering comments on top of Sorbet signatures as documentation. This PR ensures that we associate the comments with the definition they are related to.
The idea is to save the byte offset when we find sigs, so that we can collect comments starting from that point instead of the method/attribute def's offset.