Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
force-pushed
the
03-19-add_keywords_to_model
branch
from
d2fea3b to
95a68ed
Compare
This was referenced Mar 20, 2026
alexcrocha
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need keywords to provide proper completion. It's also easy to include descriptions so that we can provide documentation on both completion and hover. This PR adds the full list of keywords that we originally had in the LSP.
I went with a sorted list, which we can go through using binary search. There's a small enough number of keywords that I don't think it warrants a hashmap or even putting it inside graph (a constant is enough).