Harden SSRF validation at connection time#142
Open
kiwi0401 wants to merge 1 commit into
Open
Conversation
Re-validate hostname against SSRF denylist immediately before connecting, not just at connection save time. Prevents DNS rebinding where a hostname passes validation at save but resolves to an internal IP at connect time. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a connect-time DNS re-validation check for TCP database connections in cloud mode. Previously, hostname validation only ran when a connection was saved. This ensures the resolved IP is re-checked against the SSRF denylist before the driver opens a socket, closing a theoretical DNS rebinding window.
No user-facing changes. Existing connections continue to work as before.