Skip to content

add MultiIR contact sensor MIR_MC100#2867

Open
thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
thinkaName:multiir_door_sensor_MIR_MC100
Open

add MultiIR contact sensor MIR_MC100#2867
thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
thinkaName:multiir_door_sensor_MIR_MC100

Conversation

@thinkaName
Copy link
Copy Markdown
Contributor

@thinkaName thinkaName commented Apr 1, 2026

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Test Results

   72 files    503 suites   0s ⏱️
2 765 tests 2 753 ✅ 0 💤 12 ❌
4 723 runs  4 700 ✅ 0 💤 23 ❌

For more details on these failures, see this check.

Results for commit 549aceb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

File Coverage
All files 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/frient/frient-vibration/init.lua 87%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 549aceb

@cbaumler cbaumler requested review from aleclorimer and cjswedes April 9, 2026 21:11
@thinkaName thinkaName force-pushed the multiir_door_sensor_MIR_MC100 branch from c237c6b to a983a46 Compare April 13, 2026 03:11
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused as to whether this device uses IAS Zone to report the contact sensor state or not. The mock device does not contain the IAS Zone attribute, and the init handler removes the bind/reporting configuration setup for the cluster, and the overridden doConfigure handler means the IAS zone cluster will not be setup to enroll in zone status notification.s

Comment thread drivers/SmartThings/zigbee-contact/src/MultiIR/init.lua Outdated
Comment thread drivers/SmartThings/zigbee-contact/src/MultiIR/init.lua Outdated
Comment thread drivers/SmartThings/zigbee-contact/src/test/test_multiir_contact_tamper.lua Outdated
@thinkaName thinkaName force-pushed the multiir_door_sensor_MIR_MC100 branch from a983a46 to 1fa8f5d Compare April 15, 2026 08:31
@thinkaName thinkaName force-pushed the multiir_door_sensor_MIR_MC100 branch from 1fa8f5d to 549aceb Compare April 15, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants