Skip to content

add MultiIR Smoke Detector MIR-SM200#2874

Open
thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
thinkaName:multiir_smoke_detector_MIR_SM200
Open

add MultiIR Smoke Detector MIR-SM200#2874
thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
thinkaName:multiir_smoke_detector_MIR_SM200

Conversation

@thinkaName
Copy link
Copy Markdown
Contributor

@thinkaName thinkaName commented Apr 3, 2026 •
edited
Loading

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/QrjpD0a9gOjq

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026 •
edited
Loading

Test Results

   72 files    503 suites   0s ⏱️
2 767 tests 2 755 ✅ 0 💤 12 ❌
4 725 runs  4 702 ✅ 0 💤 23 ❌

For more details on these failures, see this check.

Results for commit 03dc986.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026 •
edited
Loading

File Coverage
All files 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/frient/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/aqara/init.lua 97% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 03dc986

@thinkaName thinkaName force-pushed the multiir_smoke_detector_MIR_SM200 branch from 0fbd389 to d907021 Compare April 3, 2026 03:38
@cbaumler cbaumler requested review from aleclorimer and cjswedes April 9, 2026 21:12
@thinkaName thinkaName force-pushed the multiir_smoke_detector_MIR_SM200 branch from d907021 to e509e7b Compare April 13, 2026 06:08
aleclorimer
aleclorimer reviewed Apr 13, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/test/test_multiir_smoke_detector.lua Outdated
}
)

test.run_registered_tests() No newline at end of file
Copy link
Copy Markdown
Contributor

@aleclorimer aleclorimer Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add newline to EOF

cjswedes
cjswedes reviewed Apr 13, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/MultiIR/init.lua Outdated
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/MultiIR/init.lua Outdated
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/test/test_multiir_smoke_detector.lua Outdated
Comment thread drivers/SmartThings/zigbee-smoke-detector/src/MultiIR/init.lua
Comment on lines +10 to +13
if zone_status:is_alarm1_set() then
device:emit_event(capabilities.smokeDetector.smoke.detected())
elseif zone_status:is_alarm2_set() then
device:emit_event(capabilities.smokeDetector.smoke.tested())
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ZoneStatus attribute bitmap, I see the following in the spec for bits that can be set:

Image

Is the alarm2 bit corresponding to the test functionality just the way the device works? Do we need to also be considering the test mode bit?

Copy link
Copy Markdown
Contributor Author

@thinkaName thinkaName Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is included in the capability definition of the smoke detector. It is also required in the Test Suite test items. If this is not added, the test will fail.

@cjswedes
Copy link
Copy Markdown
Contributor

cjswedes commented Apr 13, 2026

All new files are executable, and should be updated to be only read/write

@thinkaName thinkaName force-pushed the multiir_smoke_detector_MIR_SM200 branch from e509e7b to ae4fce4 Compare April 15, 2026 07:24
@thinkaName thinkaName force-pushed the multiir_smoke_detector_MIR_SM200 branch from ae4fce4 to 03dc986 Compare April 15, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjswedes cjswedes cjswedes left review comments

@aleclorimer aleclorimer aleclorimer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thinkaName @cjswedes @aleclorimer