[stability] Only Show New Peer On Open Channel#537
Open
schlagmichdoch wants to merge 1 commit intoSnapDrop:masterfrom
Open
[stability] Only Show New Peer On Open Channel#537schlagmichdoch wants to merge 1 commit intoSnapDrop:masterfrom
schlagmichdoch wants to merge 1 commit intoSnapDrop:masterfrom
Conversation
…open channel -> Improve stability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes Peers are shown correctly in the UI but somehow the peer to peer channel cannot be established. Therefor, sending to peers fails as there is no open channel.
This PR puts the creation of new peers to after the channel is opened and removes it when the channel is closed again.
That way, only peers with an open channel are shown. Should improve stability.
This also includes #531