fix: add missing filament_density to Snapmaker base filament profiles#188
Closed
kbaker827 wants to merge 24 commits intoSnapmaker:mainfrom
Closed
fix: add missing filament_density to Snapmaker base filament profiles#188kbaker827 wants to merge 24 commits intoSnapmaker:mainfrom
kbaker827 wants to merge 24 commits intoSnapmaker:mainfrom
Conversation
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: Snapmaker ABS @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: Snapmaker ASA @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: Snapmaker PA-CF @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: Snapmaker PET @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: Snapmaker PETG @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: Snapmaker PLA @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: Snapmaker PLA Eco @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: Snapmaker PLA Silk @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: Snapmaker PLA-CF @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: Snapmaker PVA @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: Snapmaker TPU @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where filament density was missing (defaulting to 0), causing filament weight to always display as 0g after slicing. File: PolyLite PLA @base.json
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
Fixes issues Snapmaker#114 and Snapmaker#103 where missing density (defaulting to 0) caused filament weight to display as 0g after slicing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #114 and #103 — filament density showing as 0 and filament weight displaying as 0g after slicing.
Root Cause
12 Snapmaker/PolyLite base filament profiles were missing the
filament_densityfield. SincePrintConfig.cppdefaultsfilament_densityto0.0, and weight is calculated asvolume × density × 0.001, the weight always evaluated to 0g.Other vendor profiles (e.g. Bambu) explicitly set
filament_densityin their base profiles. The Snapmaker profiles inherited the 0 default instead.Changes
Added
filament_densityto the following base profiles:Snapmaker ABS @base.jsonSnapmaker ASA @base.jsonSnapmaker PA-CF @base.jsonSnapmaker PET @base.jsonSnapmaker PETG @base.jsonSnapmaker PLA @base.jsonSnapmaker PLA Eco @base.jsonSnapmaker PLA Silk @base.jsonSnapmaker PLA-CF @base.jsonSnapmaker PVA @base.jsonSnapmaker TPU @base.jsonPolyLite PLA @base.jsonProfiles already containing correct density values were left unchanged:
Snapmaker Breakaway Support @base,Snapmaker PETG-CF @base,Snapmaker PLA Matte @base,Snapmaker PLA SnapSpeed @base,PolyTerra PLA @base.Test plan
Closes #114
Closes #103