Skip to content

Feat/merge mono and stereo mappings #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cutullic merged 2 commits into from
Apr 9, 2026
Merged

Feat/merge mono and stereo mappings #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5a0ead
fix: update doxygen definition for the unregisterClient method
cutullic Mar 17, 2026
7fc9c00
feat (interfaces): remove references to stereo mapping in service int…
cutullic Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions interfaces/api/service/IClientContextManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,7 @@ static std::string toString(const TransformStatus transformStatus)
///
enum class PipelineMode {
RELOCALIZATION_AND_MAPPING = 0, // Relocalization and mapping
RELOCALIZATION_AND_STEREO_MAPPING = 1, // Relocalization and stereo mapping
RELOCALIZATION_ONLY = 2 // Only relocalization
RELOCALIZATION_ONLY = 1 // Only relocalization
};

/// @brief Return the text definition (string) of a PipelineMode object
Expand All @@ -155,9 +154,6 @@ static std::string toString(const PipelineMode pipelineMode)
case PipelineMode::RELOCALIZATION_AND_MAPPING:
textDefinition = "RELOCALIZATION_AND_MAPPING";
break;
case PipelineMode::RELOCALIZATION_AND_STEREO_MAPPING:
textDefinition = "RELOCALIZATION_AND_STEREO_MAPPING";
break;
case PipelineMode::RELOCALIZATION_ONLY:
textDefinition = "RELOCALIZATION_ONLY";
break;
Expand Down Expand Up @@ -231,7 +227,9 @@ class XPCF_CLIENTUUID("b675a1c5-078e-4c7a-82f7-d75a7d3d6dbe") XPCF_SERVERUUID("4

/// @brief Unregister a client using its UUID
/// @param[in] clientUUID the UUID of the client to unregister
/// @return FrameworkReturnCode::_SUCCESS if the client is unregistered, else FrameworkReturnCode::_ERROR_
/// @return
/// * FrameworkReturnCode::_UNKNOWN_CLIENT_UUID if the client UUID is not currently registered
/// * else FrameworkReturnCode::_SUCCESS (client unregistered)
virtual FrameworkReturnCode unregisterClient(const std::string & clientUUID) = 0;

/// @brief Return all current clients UUID
Expand Down
8 changes: 2 additions & 6 deletions interfaces/api/service/IServiceManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,8 @@ enum class ServiceType {
RELOCALIZATION_SERVICE = 1,
RELOCALIZATION_MARKERS_SERVICE = 2,
MAPPING_SERVICE = 3,
MAPPING_STEREO_SERVICE = 4,
MAP_PROCESSING_SFM_SERVICE = 5,
MAP_PROCESSING_DENSE_MAPPING_SERVICE = 6
MAP_PROCESSING_SFM_SERVICE = 4,
MAP_PROCESSING_DENSE_MAPPING_SERVICE = 5
};

/// @brief Return the name (string) of a service according to its type
Expand All @@ -60,9 +59,6 @@ static std::string getServiceName(const ServiceType serviceType)
case ServiceType::MAPPING_SERVICE:
serviceName = "Mapping Service";
break;
case ServiceType::MAPPING_STEREO_SERVICE:
serviceName = "Stereo Mapping Service";
break;
case ServiceType::MAP_PROCESSING_SFM_SERVICE:
serviceName = "Map Processing Structure From Motion Service";
break;
Expand Down