This PR is part of consolidating rdf forms in its own lib#271
Open
timea-solid wants to merge 6 commits into
Open
This PR is part of consolidating rdf forms in its own lib#271timea-solid wants to merge 6 commits into
timea-solid wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Moves the preferences-form rendering helper out of solid-ui into this repo as part of the RDF forms consolidation effort, and updates the long chat pane to use the local implementation.
Changes:
- Added
src/preferences.jswith a localrenderPreferencesForm(...)implementation (previously fromsolid-ui). - Updated
src/longChatPane.jsto import and call the localrenderPreferencesForminstead ofUI.preferences.renderPreferencesForm.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/preferences.js | Introduces local renderPreferencesForm and wires it to existing solid-ui helpers for shared/personal defaults. |
| src/longChatPane.js | Switches the preferences sidebar to use the locally exported preferences form renderer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved renderPreferencesForm over from solid-ui (it is only used here) as part of SolidOS/solid-ui#778