Skip to content

SONARJAVA-6397 Add Mall spring project to ruling test #5630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonardo-pilastri-sonarsource wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SONARJAVA-6397 Add Mall spring project to ruling test #5630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
854eb24
Add Mall spring project to ruling test
leonardo-pilastri-sonarsource May 26, 2026
51858ad
Fix incompatible mvn toolchain
leonardo-pilastri-sonarsource May 28, 2026
34eb68f
Fix submodule git commit ref
leonardo-pilastri-sonarsource May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
[submodule "its/sources"]
path = its/sources
url = https://github.com/SonarSource/ruling_java.git
branch = lp/add-spring-ruling
Copy link
Copy Markdown

@gitar-bot gitar-bot Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Quality: Submodule .gitmodules points to feature branch instead of master

The .gitmodules file now specifies branch = lp/add-spring-ruling, which is a feature branch in the ruling_java repository. If this branch is deleted or not merged into the default branch of that repo before this PR lands on master, the submodule tracking will break for anyone doing git submodule update --remote. Typically submodules should track a stable branch (e.g., master or main). Either merge the feature branch in ruling_java first and remove the branch line (so it defaults to the remote HEAD), or update it to point to the stable branch after the ruling_java PR is merged.

Remove the branch line so the submodule tracks the default branch of the remote (after merging lp/add-spring-ruling into the default branch of ruling_java):

[submodule "its/sources"]
	path = its/sources
	url = https://github.com/SonarSource/ruling_java.git
  • Apply fix

Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎

12 changes: 12 additions & 0 deletions its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,18 @@ private static void copyFile(Path source, Path targetDir) {
}
}

@Test
public void spring_mall() throws Exception {
String projectName = "mall";
MavenBuild build = test_project("com.macro.mall:mall", projectName);
build
.setProperty("docker.skip", "true")
.setProperty("java.version", "21")
.setProperty("maven-bundle-plugin.version", "5.1.4")
.setProperty("maven.javadoc.skip", "true");
executeBuildWithCommonProperties(build, projectName);
}

@Test
public void guava() throws Exception {
String projectName = "guava";
Expand Down
Loading
Loading