SONARJAVA-6425 Support records in S1068

[tomasz-tylenda-sonarsource]

---

Summary by Gitar

• Check logic:
  • Updated UnusedPrivateFieldCheck to include Tree.Kind.RECORD in nodesToVisit and switch case.
• Test updates:
  • Added test case for record private field usage in UnusedPrivateFieldCheck.java test sources.

_{This will update automatically on new commits.}

[hashicorp-vault-sonar-prod]

SONARJAVA-6425

[gitar-bot]

💡 Edge Case: Test missing: record instance field false positive coverage

The test only covers private static final fields in records. Records can also have explicitly declared private instance fields (though rare). More importantly, record components generate implicit private final fields (e.g., int a in record MyRecord(int a)). It would strengthen confidence to add a test verifying the rule does NOT flag record component fields as unused, since they are accessed via the implicit accessor method. For example:

record MyRecordCompliant(int a) {
  // 'a' should not be flagged
  private static final int USED = 1;
  int sum() { return a + USED; }
}

This would guard against future regressions if the AST representation changes.

_{Was this helpful? React with 👍 / 👎}

[asya-vorobeva]

I think gitar-bot's comment makes a perfect sense. Let's add this test case: int sum() { return a + XXX; }

[tomasz-tylenda-sonarsource]

I think gitar-bot's comment makes a perfect sense. Let's add this test case: int sum() { return a + XXX; }

Done.

The bot also talks about "explicitly declared private instance fields", but I don't think it is possible.

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[gitar-bot]

Code Review ✅ Approved 1 resolved / 1 findings

Updates UnusedPrivateFieldCheck to support Java records, resolving the false positive coverage issue for record instance fields. No additional findings detected.

✅ 1 resolved

✅ Edge Case: Test missing: record instance field false positive coverage

📄 java-checks-test-sources/default/src/main/java/checks/unused/UnusedPrivateFieldCheck.java:197-200
The test only covers private static final fields in records. Records can also have explicitly declared private instance fields (though rare). More importantly, record components generate implicit private final fields (e.g., int a in record MyRecord(int a)). It would strengthen confidence to add a test verifying the rule does NOT flag record component fields as unused, since they are accessed via the implicit accessor method. For example:

record MyRecordCompliant(int a) {
  // 'a' should not be flagged
  private static final int USED = 1;
  int sum() { return a + USED; }
}

This would guard against future regressions if the AST representation changes.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}