Skip to content

CLI-536 Use the declarative framework for the CAG feature#331

Draft
damien-urruty-sonarsource wants to merge 1 commit into
masterfrom
task/dam/declarative-cag-skill
Draft

CLI-536 Use the declarative framework for the CAG feature#331
damien-urruty-sonarsource wants to merge 1 commit into
masterfrom
task/dam/declarative-cag-skill

Conversation

@damien-urruty-sonarsource
Copy link
Copy Markdown
Contributor

@damien-urruty-sonarsource damien-urruty-sonarsource commented May 28, 2026


Summary by Gitar

  • Declarative Refactoring:
    • Migrated Context Augmentation (CAG) from legacy state extensions to the declarative integration framework.
    • Replaced agentExtensions state with modular features and dependencies within integrations.
  • Dependency & Integration Management:
    • Added context-augmentation-binary as a shared declarative dependency in the integration registry.
    • Updated post-update and state-manager to handle the new declarative installation and refresh schema.
  • Integration Logic:
    • Refactored integrate commands (claude, copilot, codex) to use the new ContextAugmentationFeature for feature installation.
    • Centralized feature, runtime, and attribute resolution logic to ensure consistent tool behavior.
  • Test Improvements:
    • Updated integration and unit tests to validate the new state schema and declarative dependency lifecycle.

This will update automatically on new commits.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented May 28, 2026

CLI-536

Comment thread src/lib/post-update.ts
@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/dam/declarative-cag-skill branch from d8eeaea to aa10c15 Compare May 28, 2026 06:55
@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/dam/feature-vs-dependency branch from 00f4ab2 to 1039d89 Compare May 28, 2026 07:28
Base automatically changed from task/dam/feature-vs-dependency to master May 28, 2026 08:55
@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/dam/declarative-cag-skill branch from aa10c15 to 310b065 Compare May 28, 2026 09:11
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 28, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Migrates the Context Augmentation feature to the declarative framework by centralizing integration logic and dependency management. The redundant attribute validation in the refresh feature has been successfully resolved.

✅ 1 resolved
Quality: Redundant attrs validation in tryRefreshContextAugmentationFeature

📄 src/lib/post-update.ts:228-234 📄 src/lib/post-update.ts:277-280
The function tryRefreshContextAugmentationFeature (line 277) re-validates resolveContextAugmentationFeatureAttrs(entry.feature.attrs) even though its only caller refreshContextAugmentationFeature (line 228) already performed the same check and would have returned false if attrs were missing. Since tryRefreshContextAugmentationFeature is a private module function with a single call site, the second check is dead code that can never trigger.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant