Deduplicate unsigned-integer Java warning per proto location (synced with PR #300)#299
Deduplicate unsigned-integer Java warning per proto location (synced with PR #300)#299Copilot wants to merge 10 commits into
Conversation
Agent-Logs-Url: https://github.com/SpineEventEngine/validation/sessions/68b0cb8a-7b52-4402-9110-5252ffe52f56 Co-authored-by: alexander-yevsyukov <3116444+alexander-yevsyukov@users.noreply.github.com>
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
Please see my documentation request.
Agent-Logs-Url: https://github.com/SpineEventEngine/validation/sessions/e964dc0d-3376-4fb4-bdb2-ae3dce54cab8 Co-authored-by: alexander-yevsyukov <3116444+alexander-yevsyukov@users.noreply.github.com>
Addressed the documentation request by adding KDoc for the warning-deduplication object in commit Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
Please see my questions.
Agent-Logs-Url: https://github.com/SpineEventEngine/validation/sessions/35bfa4c1-1992-4221-b4ab-a9c658269d4c Co-authored-by: alexander-yevsyukov <3116444+alexander-yevsyukov@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SpineEventEngine/validation/sessions/35bfa4c1-1992-4221-b4ab-a9c658269d4c Co-authored-by: alexander-yevsyukov <3116444+alexander-yevsyukov@users.noreply.github.com>
Addressed the review questions in commits Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/SpineEventEngine/validation/sessions/f90f333f-cd83-44ed-9a22-42cbbad478ae Co-authored-by: alexander-yevsyukov <3116444+alexander-yevsyukov@users.noreply.github.com>
Done in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
Merge in the branch eliminate-duplicated-error-placeholders from #300 PR.
This branch has the /bump-version skill. Use this skill for updating dependency reports.
…d-error-placeholders' into copilot/fix-duplicated-warning-message # Conflicts: # java/src/main/kotlin/io/spine/tools/validation/java/generate/option/bound/BoundedFieldGenerator.kt # version.gradle.kts Co-authored-by: alexander-yevsyukov <3116444+alexander-yevsyukov@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SpineEventEngine/validation/sessions/f7e81e60-437d-4fd5-a6c4-7549d5cd987a Co-authored-by: alexander-yevsyukov <3116444+alexander-yevsyukov@users.noreply.github.com>
Done: merged Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
@copilot, I put the comment for the bump-version skill in the comments. Please use it.
Done — I used the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
@copilot, update the version of Validation used in the documentation code snippets (.md files). Use ./gradlew :docs:checkSamples to verify that versions are updated.
…ns/b81d4af0-e5e0-46d0-adb7-40a8f1c67aa7 Co-authored-by: alexander-yevsyukov <3116444+alexander-yevsyukov@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Building Java validators for unsigned numeric bounds could emit the same warning twice for the same file/span (e.g.,
uint32/uint64in a single option path). This change keeps the warning intact but guarantees it is reported once per source location.Warning reporting behavior
min/max/rangepath throughBoundedFieldGenerator).Deduplication mechanism
UnsignedIntegerWarnings) keyed by proto location.file + spanare ignored.Review follow-ups
UnsignedIntegerWarnings.@VisibleForTesting.internalmodifiers inside theinternalobject.Focused coverage
Versioning
validationVersionto2.0.0-SNAPSHOT.421so this PR remains ahead when merged after Eliminate duplicated error placeholders #300.Branch sync requested in review
eliminate-duplicated-error-placeholdersfrom PR Eliminate duplicated error placeholders #300 into this branch.java/src/main/kotlin/io/spine/tools/validation/java/generate/option/bound/BoundedFieldGenerator.ktversion.gradle.kts2.0.0-SNAPSHOT.421after conflict resolution.Dependency reports
2.0.0-SNAPSHOT.421:docs/dependencies/pom.xmldocs/dependencies/dependencies.md