Add linkClass property to MenuItem component#2210
Open
chris-doucette-stack wants to merge 4 commits intobetafrom
Open
Add linkClass property to MenuItem component#2210chris-doucette-stack wants to merge 4 commits intobetafrom
chris-doucette-stack wants to merge 4 commits intobetafrom
Conversation
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 7827489 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Figma
Summary
This PR adds a new property,
linkClass, to theMenuItemcomponent. This new property allows users to add classes directly to the link/button element. I'd like to use this particular css class to adjust the border radius of the button as well as addingis-selectedto it. The latter may better be handled through the selected prop but didn't want there to be css clashes betweenis-selectedandis--selectedTesting
I added a test to make sure this is covered. I also ran a manual test where I added the
linkClassprop to aMenuItemcomponent just to make sure the css was applied properly, you can do the same if you'd like by altering the Menu.stories.svelte file.