Skip to content

fix(st2client): fix TypeError when displaying help for actions with mixed parameter position types #6375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balgaly wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −3
Open

fix(st2client): fix TypeError when displaying help for actions with mixed parameter position types #6375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions st2client/st2client/commands/action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,14 +1206,19 @@ def _get_parameter_sort_value(self, parameters, name):
By default, parameters are sorted using "position" parameter attribute.
If this attribute is not available, parameter is sorted based on the
name.

Returns a tuple (tier, value) so that parameters with a numeric position
sort before those without, and mixed int/str comparisons are avoided.
"""
parameter = parameters.get(name, None)

if not parameter:
return None
return (1, 0, name)

sort_value = parameter.get("position", name)
return sort_value
position = parameter.get("position", None)
if position is not None:
return (0, int(position), "")
return (1, 0, name)

def _get_inherited_env_vars(self):
env_vars = os.environ.copy()
Expand Down
Loading