-
Notifications
You must be signed in to change notification settings - Fork 14
Update workflows to only add a single comment for how to run an image #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
|
To run the UAA server image built for this pull request: docker run --rm -d --pull=always -p 8080:8080 --name uaa-pr steeltoe.azurecr.io/uaa-server:pr-54 |
|
To run the Eureka server image built for this pull request: docker run --rm -d --pull=always -p 8761:8761 --name eureka-pr steeltoe.azurecr.io/eureka-server:pr-54 |
|
To run the Spring Cloud Config Server image built for this pull request: docker run --rm -d --pull=always -p 8888:8888 --name config-pr steeltoe.azurecr.io/config-server:pr-54 |
|
@copilot the spring boot admin server workflow is failing because one of the patch files isn't matching. Update spring-boot-admin/patches/build.gradle.patch to look like this: |
Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
|
To run the Spring Boot Admin server image built for this pull request: docker run --rm -d --pull=always -p 9099:9099 --name sba-pr steeltoe.azurecr.io/spring-boot-admin:pr-54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR resolves the issue of workflows creating redundant comments on each run by implementing an idempotent comment update mechanism. Instead of creating a new comment every time a workflow runs, each workflow now searches for its existing comment (using a unique HTML marker) and updates it if found, or creates it if not. This approach avoids the race condition issues encountered in PR #50 where --edit-last caused different workflows to overwrite each other's comments.
Changes:
- Updated all four build workflow files to use unique HTML comment markers for idempotent comment updates
- Modified the spring-boot-admin build.gradle patch to match the current file structure
- Added pagination support (per_page: 100) and bot user filtering based on code review feedback
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/build_config_server.yaml |
Replaced simple comment creation with marker-based update-or-create logic using unique marker IMAGE_INSTRUCTIONS_CONFIG_SERVER |
.github/workflows/build_eureka_server.yaml |
Replaced simple comment creation with marker-based update-or-create logic using unique marker IMAGE_INSTRUCTIONS_EUREKA_SERVER |
.github/workflows/build_springboot_admin_server.yaml |
Replaced simple comment creation with marker-based update-or-create logic using unique marker IMAGE_INSTRUCTIONS_SPRING_BOOT_ADMIN |
.github/workflows/build_uaa_server.yaml |
Replaced simple comment creation with marker-based update-or-create logic using unique marker IMAGE_INSTRUCTIONS_UAA_SERVER |
spring-boot-admin/patches/build.gradle.patch |
Updated patch to remove version upgrade section and adjust line numbers to match current file structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TimHess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bart-vmware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice!
- Comments stay at their original position
- When a comment gets updated with the same contents, its last-modified time is retained at the original value (no "edited" entry)
- After changing the comment myself, the next build restores it to the original value (with "edited" history, see picture below)
- I don't get a new email when the content of an existing comment has changed
- When I change the workflow to produce a different comment, it gets added to the history of the existing comment (picture below)
--edit-last)build_config_server.yamlbuild_eureka_server.yamlbuild_springboot_admin_server.yamlbuild_uaa_server.yamlper_page: 100to handle PRs with many commentsgithub-actions[bot]userSolution
Each workflow now:
<!-- IMAGE_INSTRUCTIONS_CONFIG_SERVER -->)github-actions[bot]userThis approach ensures:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.