Skip to content

Add clarifying comments for service discovery port registration #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add clarifying comments for service discovery port registration #129

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
123e17f
Initial plan
Copilot Jan 29, 2026
797a10e
Add Urls configuration and helpful comments for service discovery
Copilot Jan 29, 2026
207ff56
Remove Urls config per Steeltoe v4 dynamic port detection; keep helpf…
Copilot Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Content/NetCoreTool.Template.WebApi/CSharp/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@
builder.Configuration.AddPlaceholderResolver();
#endif
#if (HasAnyNonAzureHostingInSteeltoeV3)
// Configures the application to listen on the port(s) provided by the cloud platform.
builder.UseCloudHosting();
#endif
#if (HostingCloudFoundryOption)
Expand Down Expand Up @@ -221,12 +222,17 @@
builder.Services.ConfigureCloudFoundryOptions(builder.Configuration);
#endif
#if (HasAnyDiscoveryInSteeltoeV3)
// Registers this application with a service discovery provider (e.g., Eureka, Consul).
builder.Services.AddDiscoveryClient(builder.Configuration);
#else
#if (HasDiscoveryConsulInSteeltoeV44)
// Registers this application with Consul for service discovery.
// Port registration is automatically detected from the server's listening addresses.
builder.Services.AddConsulDiscoveryClient();
#endif
#if (HasDiscoveryEurekaInSteeltoeV4)
// Registers this application with Eureka for service discovery.
// Port registration is automatically detected from the server's listening addresses.
builder.Services.AddEurekaDiscoveryClient();
#endif
#endif
Expand Down