Fix installed-build launch crash (resources.pri) and dead tray menu items

[StuartMeeks]

Two fixes for the installed (Velopack) build. Both verified on the Win11 build host with the exact CI release config (dotnet publish -c Release -r win-x64 --self-contained true, R2R on); a raw published exe was launched interactively (the launch crash isn't reproducible from a VS Debug run).

1. Installed builds crashed on launch — missing resources.pri

Installed builds crashed on launch on multiple machines with a blank window; the crash log showed a XamlParseException at ShellPage..ctor → LoadComponent with no inner exception. VS Debug was unaffected.

Root cause: the self-contained Release publish shipped no app resources.pri — only the WindowsAppSDK framework PRIs. With the app's resource index absent, ms-appx:/// lookups for the app's own XAML failed. App.xaml limped through on the framework PRIs (so the app reached OnLaunched); the first app-specific page (ShellPage) died.

Enriching CrashLog to dump HRESULT + Exception.Data surfaced the real error (not in Message):

HRESULT: 0x802B000A
Data[RestrictedDescription]: Cannot locate resource from 'ms-appx:///Views/ShellPage.xaml'.

Two compounding defects:

1. Publish never copied the app PRI — generated into bin but dropped by dotnet publish, because the WinUI PRI/packaging targets weren't imported. EnableMsixTooling=true (required for unpackaged self-contained WinUI per the Windows App SDK docs) wires in the copy-to-publish step.
2. Wrong PRI name — an unpackaged app auto-loads only resources.pri from the exe dir, but the build names it after the assembly (Snipdeck.App.pri), which the runtime never loads. ProjectPriFileName pins the conventional name. See microsoft-ui-xaml#10856.

<EnableMsixTooling>true</EnableMsixTooling>
<ProjectPriFileName>resources.pri</ProjectPriFileName>

After: publish ships resources.pri (1.4 MB, all XBF); the app launches to the shell. (Ruled out R2R along the way — both R2R on/off crashed identically.)

2. Tray menu "Show Snipdeck" and "Exit" did nothing

In an unpackaged app, H.NotifyIcon's default context menu is a native Win32 PopupMenu, built from the MenuFlyout by invoking each item's Command — it does not raise the WinUI routed Click event the items were wired to. (Left-click worked because it already used a Command.) Switched the items to the existing RelayCommand.

Diagnostics

CrashLog now always logs HRESULT and Exception.Data — the WinRT RestrictedDescription in Data is what pinpointed the missing resource (Message was only "XAML parsing failed").

🤖 Generated with Claude Code