Add check for conditional variables in attachment content (EG416)#48
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
nonprofittechy
requested changes
Jun 3, 2026
Member
nonprofittechy
left a comment
nonprofittechy
left a comment
There was a problem hiding this comment.
Really close, but our template interviews all use the attachment-specific skip undefined modifier instead of the global feature, so we should support both in this rule
Member
|
Also can't quite tell what the test error is. Is it just an inverted assertion? |
Contributor
Author
the 3 failing tests are in |
nonprofittechy
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check for attachment content blocks that reference variables which are only conditionally asked (show if/hide if). If the condition isn't met at runtime, docassemble tries to render the variable, can't find it, and the interview gets stuck.
Respects Mako % if guards so correctly guarded references don't get flagged.