Fix focus reset after AJAX page navigation#31
Open
nonprofittechy wants to merge 4 commits into
Open
Conversation
Ensure the fallback page title target can receive programmatic focus after Continue-style navigation.\n\nAlso regenerate the shipped JS bundles so the focus-management change is present in the assets served to browsers.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Proposed fix for tab navigation issue that MATC pointed out to us; needs some testing. |
|
I like the idea, but IMO it should target the Question title, not the page / interview title. Focusing to the page title doesn't really fix the number of tab presses it takes for a user to get to main content of the page, but starting focus on the question title would bring the user right there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#dapagetitlespan programmatically focusable withtabindex="-1"Problem
After activating Continue and landing on a new page, the fallback focus logic could immediately blur the focused element or try to focus a non-focusable page title span. That left keyboard users in the middle of the page instead of at the top-most meaningful target.
Result
Keyboard and assistive-technology users now land on a stable, top-of-page focus target after AJAX page transitions, which keeps the tab order aligned with WCAG expectations.