Skip to content

Enhance dataset templates with coordinate specifications#822

Merged
BrianMichell merged 1 commit into
TGSAI:mainfrom
BrianMichell:feat/schema-resolver-template-hooks
Jun 1, 2026
Merged

Enhance dataset templates with coordinate specifications#822
BrianMichell merged 1 commit into
TGSAI:mainfrom
BrianMichell:feat/schema-resolver-template-hooks

Conversation

@BrianMichell
Copy link
Copy Markdown
Collaborator

  • Introduce declare_coordinate_specs method in various seismic dataset templates to define non-dimension coordinates.
  • Implement CoordinateSpec class for better structure and validation of coordinate specifications.
  • Update existing templates to utilize the new coordinate declaration method, ensuring consistency across 2D and 3D seismic templates.
  • Add temporary drift guard to validate synchronization between declared and built coordinates, to be removed in future releases.
  • Introduce unit tests for schema resolution and coordinate specification validation to ensure robustness.

* Introduce `declare_coordinate_specs` method in various seismic dataset templates to define non-dimension coordinates.
* Implement `CoordinateSpec` class for better structure and validation of coordinate specifications.
* Update existing templates to utilize the new coordinate declaration method, ensuring consistency across 2D and 3D seismic templates.
* Add temporary drift guard to validate synchronization between declared and built coordinates, to be removed in future releases.
* Introduce unit tests for schema resolution and coordinate specification validation to ensure robustness.
@BrianMichell BrianMichell added the refactoring Refactoring label Jun 1, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 96.09929% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.37%. Comparing base (c3ba558) to head (ab9f233).
⚠️ Report is 237 commits behind head on main.

Files with missing lines Patch % Lines
src/mdio/builder/templates/base.py 75.75% 7 Missing and 1 partial ⚠️
src/mdio/ingestion/schema_resolver.py 96.87% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
+ Coverage   85.30%   92.37%   +7.06%     
==========================================
  Files          46      130      +84     
  Lines        2219     7830    +5611     
  Branches      306      468     +162     
==========================================
+ Hits         1893     7233    +5340     
- Misses        281      515     +234     
- Partials       45       82      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BrianMichell BrianMichell merged commit c3f32a9 into TGSAI:main Jun 1, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant