UX: Show login button when guests are not allowed

[samuelwei]

Type

• Bugfix
• Feature
• Documentation
• Refactoring (e.g. Style updates, Test implementation, etc.)
• Other (please describe): UX

Checklist

• Code updated to current develop branch head
• Passes CI checks
• Is a part of an issue
• Tests added for the bugfix or newly implemented feature, describe below why if not
• Changelog is updated
• Documentation of code and features exists

Changes

• Instead of showing a reload button (user can always reload via the browser) a login button is shown

Other information

Before

After

Summary by CodeRabbit

• Changed
  • Restricted-room error screen now shows a login button (which returns users to the room after signing in) instead of a reload button; footer spacing adjusted for clarity.
• Tests
  • Automated frontend tests updated to reflect the new login link and the revised reload behavior.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bdf92ffd-e49d-4e44-bf34-34ef6c84d697

📥 Commits

Reviewing files that changed from the base of the PR and between c170da8 and 541f8ef.

📒 Files selected for processing (1)

• CHANGELOG.md

---

Walkthrough

Replaced the "reload" button with a "login" router-link in the RoomsView guest-not-allowed footer, updated related Cypress tests to remove reload-button assertions/use cy.reload() where appropriate, and added a changelog entry documenting the UI change.

Changes

Cohort / File(s)	Summary
Documentation CHANGELOG.md	Added an "Unreleased" change noting the room view shows a login button instead of a reload button for guests without access and added link reference [#2321].
UI Component resources/js/views/RoomsView.vue	Replaced the data-test="reload-room-button" reload button with a router-link data-test="login-room-button" pointing to /login?redirect=...; added mt-4 spacing to the footer container and removed reload click behavior.
E2E Tests tests/Frontend/e2e/RoomsView*.cy.js, tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js	Removed assertions/clicks for the reload button, added assertions for the login link href where applicable, and replaced some UI-triggered reload clicks with cy.reload(); updated test flows to wait for @roomRequest after reloads.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• UX: Show login button when guests are not allowed #2321: Makes the same RoomsView change—replaces guest reload button with login link and updates tests/changelog.
• Fix Greenlight v2 migration with 6 digit access codes and leading zeros #2433: Related updates to RoomsView guest login/access-code handling; touches similar UI/login flows.

Suggested labels

frontend, UI

Suggested reviewers

• Sabr1n4W
• achtadef

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description includes the Type (UX), Changes section explaining the main modification, and visual before/after images. However, critical template sections are incomplete: 'Fixes #' is blank, issue link is unchecked, and most checklist items are unmarked.	Complete the 'Fixes #' field with the related issue number (#2321), verify and mark applicable checklist items, and confirm all checks have been addressed before merging.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'UX: Show login button when guests are not allowed' accurately and concisely describes the main change—replacing a reload button with a login button in the guest restriction UI.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ux-show-login-button-when-guest-not-allowed

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.69%. Comparing base (42f6c6f) to head (541f8ef).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #2321      +/-   ##
=============================================
- Coverage      96.70%   96.69%   -0.01%     
  Complexity      1911     1911              
=============================================
  Files            445      445              
  Lines          12892    12892              
  Branches        2077     2077              
=============================================
- Hits           12467    12466       -1     
- Misses           425      426       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cypress]

PILOS    Run #2923

Run Properties:   Passed #2923  •  541f8ef27b: UX: Show login button when guests are not allowed

Project	PILOS
Branch Review	ux-show-login-button-when-guest-not-allowed
Run status	Passed #2923
Run duration	07m 34s
Commit	541f8ef27b: UX: Show login button when guests are not allowed
Committer	Samuel Weirich
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	607
View all changes introduced in this branch ↗︎

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@resources/js/views/RoomsView.vue`:
- Around line 53-54: The login CTA currently uses $route.fullPath (in
RoomsView.vue router-link) which preserves the personalized token; change the
redirect query to point to the canonical room route without the token by passing
a named route + id param (e.g. set query: { redirect: { name: 'room', params: {
id: $route.params.id } } } or equivalent using the app's canonical room route
name) so the post-login redirect goes to the canonical room page and does not
include the token.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 58e63a11-d3e3-4b8d-9715-508a31b2a1bb

📥 Commits

Reviewing files that changed from the base of the PR and between 42f6c6f and c170da8.

📒 Files selected for processing (5)

• CHANGELOG.md
• resources/js/views/RoomsView.vue
• tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js
• tests/Frontend/e2e/RoomsViewGeneral.cy.js
• tests/Frontend/e2e/RoomsViewMeetings.cy.js

💤 Files with no reviewable changes (1)

• tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js