ci: draft-then-publish releases to close the empty public window#21
Merged
Conversation
Previously create-release published an empty release immediately, leaving a 1-2 minute window where the public saw a partial release while the upload matrix attached assets. Now the release is created as a draft, the upload matrix attaches all 10 assets to the draft (still serialized so there is no create race), and a final publish-release job flips draft to false only after every asset is present. The release becomes public in one step with the full asset set. The upload-assets matrix sets draft: true explicitly because the action's draft input defaults to false and would otherwise publish the draft early on each update call. Preserves the 5 platform targets, asset names, 10 total assets, checksums, GITHUB_TOKEN, and contents: write only on the release-related jobs. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create-release now makes a DRAFT, upload-assets matrix attaches all 10 assets to the draft (serialized, no race), and a new publish-release job (needs upload-assets) flips draft to false only after all assets are present. Closes the 1-2 min window where the public saw a partial/empty release. upload-assets sets draft: true explicitly so updates do not publish early. Preserves 5 targets, asset names, 10 assets, checksums, GITHUB_TOKEN, contents: write on release jobs only. Validates via v0.6.1-rc4.
Made with Cursor