Use unordered_map instead of vector for primitives#384
Draft
MaartenS11 wants to merge 1 commit into
Draft
Conversation
Technically this should be faster than a linear search + it allows overwriting primitives that you already have. For example:
```cpp
wac->interpreter->register_primitive("chip_digital_write", [](Module *m) -> bool {
pop_args(2);
printf("chip_digital_write\n");
return true;
}, &twoToNoneU32);
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technically this should be faster than a linear search + it allows overwriting primitives that you already have. For example:
This overwriting is particularly useful for the concolic version of the interpreter so that it can have custom implementations that for example push symbolic variables.
Size difference
Size increase by 688 bytes
After change:
Current main branch: