refactor(hig): bind .defaultAction/.cancelAction and confirm Remove Provider#1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Round 2 of macOS HIG cleanup, addressing remaining issues found while reviewing the broader codebase:
ConnectionTagEditor,ConnectionGroupPicker— added.keyboardShortcut(.cancelAction)..keyboardShortcut(.return)inConnectionTagEditor,ConnectionGroupPicker,BackupResultSheet— changed to.keyboardShortcut(.defaultAction), which also auto-tints the button as the platform default action.PairingApprovalSheet— added.buttonStyle(.borderedProminent)+.keyboardShortcut(.defaultAction)on the Approve button. Previously plain styled despite being the primary action.AIProviderDetailSheet— "Remove Provider" no longer deletes immediately on click; now triggers a native.confirmationDialogwith a typed message. Destructive actions should always confirm.LicenseActivationSheet— removed a duplicate.keyboardShortcut(.cancelAction)modifier left over from a previous edit.Test plan
ConnectionTagEditor: Esc dismisses, Return creates tag, primary button shows accent tintConnectionGroupPicker: Esc dismisses, Return creates group, primary button shows accent tintBackupResultSheet: Return dismisses the Done button correctlyPairingApprovalSheet: Approve button visually prominent (blue), Return triggers it, Esc deniesAIProviderDetailSheet: clicking "Remove Provider" now shows a confirmation dialog before deleting; cancel keeps the provider intactLicenseActivationSheet: Esc still dismisses the sheet (only one cancelAction binding now)