fix(ai-chat): sanitize tool schemas for Gemini function_declarations#1276
Open
datlechin wants to merge 2 commits into
Open
fix(ai-chat): sanitize tool schemas for Gemini function_declarations#1276datlechin wants to merge 2 commits into
datlechin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sending a message to Gemini with AI Chat tools enabled fails with HTTP 400:
Root cause:
ChatToolSchemaBuilderproduces a JSON Schema with:additionalProperties: falseon every object schematype: ["string", "null"]for fields markedoptional: trueBoth forms work for OpenAI and Claude, but Gemini's
function_declarationsAPI rejects them. Gemini's schema is closer to Protocol Buffers — strict single types, noadditionalProperties, optional fields use anullable: trueflag instead.Fix
New static
GeminiProvider.sanitizeSchemaForGemini(_:):additionalPropertiesat any depthtype: [X, "null"]totype: Xplusnullable: truerequired,description, and other fields untouchedApplied to each tool's
inputSchemabefore serializing intoparameters. OpenAI/Claude paths are untouched — they still receive the unmodified shared schema.Test plan
GeminiProviderEncodingTests.swiftcovering: stripadditionalProperties, rewrite optional types, preserve non-nullable types, recurse into array items, preserve enums and required