fix(ai-chat)!: always require user approval for destructive operations#1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security issue
The user reported: AI dropped a table with no confirmation prompt. Reproduction:
The `confirm_destructive_operation` tool's `confirmation_phrase` parameter is security theater — the AI just types it. The real user gate is supposed to be the approval UI, but `computeInitialApprovalState` was auto-approving `.agentOnly` tools whenever the connection used Silent safe mode (and forever once "Always Allow" was clicked).
Fix
`AIChatViewModel+ToolApproval.swift` — `computeInitialApprovalState(for:)` now:
`persistAlwaysAllowed(toolName:)` — refuses to record "Always Allow" for `.agentOnly` tools, so the destructive confirmation cannot be permanently skipped.
Tests
5 new tests in `DestructiveToolApprovalTests`:
All pass.
Breaking change marker
The `!` in the commit type signals a behavior change: users in Silent safe mode who previously dropped tables without dialogs will now see an approval prompt. This is intentional and the correct behavior.
Test plan