fix: Fix update notification crash #1278
Open
+41
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sola-ris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't raise exceptions in
get_most_recent_release_versionto prevent crashes if they bubble up intoQtDriver, log failures instead.The about modal will show
9.5.6 (Latest Release: UNKNOWN)if the GitHub API is unavilableI have only tested the issue trough the about modal, since I couldn't make
QtDriver::startwork in tests.In case of timeouts, the UI willstill be blocked until the request times out.
Fixes #1277
Tasks Completed