Rectify: Test Filter Manifest Missing Workspace for SKILL.md Changes — PART A ONLY#3378
Merged
Trecek merged 2 commits intoMay 31, 2026
Conversation
… gaps Introduces reverse-dependency declaration infrastructure (SOURCE_DEPENDENCIES registry + parametrized tests) to enforce that each manifest pattern's directory list covers all test directories that consume those source files. Fixes 5 confirmed manifest gaps: workspace/ missing from both SKILL.md patterns, planner/ missing from skills_extended and agents patterns, contracts/ missing from assets pattern, hooks/ missing from registry.sha256 pattern. Adds test_manifest_entry_path_exists to catch typos/stale directory references. Registers test_manifest_directory_completeness.py as an unconditional infra file (count 6 → 7) so it always runs in conservative filter mode. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…aming consistency Sibling file test_manifest_completeness.py uses underscore-prefixed private constants for all module-level registries. Align naming convention. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Trecek
force-pushed
the
test-filter-manifest-missing-workspace-for-skill-md-changes/3332
branch
from
5a9ab25 to
9cec5d6
Compare
Trecek
deleted the
test-filter-manifest-missing-workspace-for-skill-md-changes/3332
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test filter manifest maps non-Python file patterns to test directories, but the directory lists are never validated for completeness. The manifest correctly matches SKILL.md files to some test directories, but silently omits
workspace/(11 sensitive tests) andplanner/(6 contract tests). The root architectural weakness is thattest_manifest_completeness.pyvalidates only the pattern-to-file axis (every file has a pattern, every pattern has a file) but not the pattern-to-test-directory axis (every pattern lists all test directories that consume the matched files). This makes the manifest a manually-curated, unvalidated routing table where drift is invisible.The architectural fix introduces a reverse-dependency declaration mechanism: a
SOURCE_DEPENDENCIESregistry in a new test module maps test directories to manifest patterns they consume, and parametrized tests cross-reference these declarations against the manifest's directory lists — catching any missing directory at test collection time.Part B will cover broader manifest audit tooling and automated dependency discovery.
Requirements
Conflict Resolution Decisions
The following files had merge conflicts that were automatically resolved.
Changed Files
New (★):
tests/infra/test_manifest_directory_completeness.pyModified (●):
.autoskillit/test-filter-manifest.yamltests/_test_filter.pytests/infra/CLAUDE.mdtests/infra/test_manifest_completeness.pytests/test_test_filter_tiered_always_run.pyCloses #3332
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/remediation-20260530-185817-415989/.autoskillit/temp/rectify/rectify_test_filter_manifest_directory_completeness_2026-05-30_190500.md🤖 Generated with Claude Code via AutoSkillIt
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown