Add MODULE_CASCADE_CORE Entries for 5 Unclassified Core Modules#3380
Merged
Trecek merged 3 commits intoMay 31, 2026
Merged
Conversation
… core modules Adds cascade entries for _type_constants_env, _type_constants_features, _type_constants_registries, _type_exceptions, and _step_context to route them to their actual import consumers instead of falling through to the full 18-directory cascade. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…RE entries - Expand expected_stems to 38 entries (was 33) - Add 5 cascade value assertions (T2) to TestModuleCascadeCore - Add 5 routing tests (T3) to TestBuildTestScopeCoreCascade - Add REQ-FILT-007 completeness guard TestCoreStemCompleteness Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Prevents the REQ-FILT-007 completeness assertion from trivially passing when pytest runs from a non-root directory where the relative path resolves to zero files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Trecek
force-pushed
the
add-module-cascade-core-entries-for-5-unclassified-core-modu/3368
branch
from
28edd17 to
343b192
Compare
Trecek
deleted the
add-module-cascade-core-entries-for-5-unclassified-core-modu/3368
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 5 missing
MODULE_CASCADE_COREentries intests/_test_filter.pyfor core modules created by the monolithic file split (May 24) and GitHub API log rectification (May 29). These modules currently fall through to the full 18-directory cascade instead of narrowed cascades matching their actual import consumers. Also add a completeness guard test (REQ-FILT-007) to prevent future regressions when new core modules are created.Files changed:
tests/_test_filter.py,tests/test_test_filter_core_cascade.pyRequirements
_type_constants_envtoMODULE_CASCADE_COREwith cascade{cli, config, core, execution, recipe, server, smoke_utils, workspace}_type_constants_featurestoMODULE_CASCADE_COREwith cascade{cli, config, core, fleet, recipe, server, workspace}_type_constants_registriestoMODULE_CASCADE_COREwith cascade{cli, config, core, pipeline, recipe, server, workspace}_type_exceptionstoMODULE_CASCADE_COREwith cascade{core, fleet, recipe, server}_step_contexttoMODULE_CASCADE_COREwith cascade{core, execution, pipeline, server}tests/test_test_filter_core_cascade.pyfor all 5 entries (both value assertions and routing tests)src/autoskillit/core/for.pyfile stems and asserts each appears in either_CORE_UNIVERSAL_MODULESorMODULE_CASCADE_CORE— this prevents future monolithic file splits from silently falling through to the full cascadeImplementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260530-195159-043829/.autoskillit/temp/make-plan/add_module_cascade_core_entries_plan_2026-05-30_195500.mdCloses #3368
🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown