CI workflow#8
Merged
Merged
Conversation
React Flow was first added with --legacy-peer-deps, which left the lock missing peer packages (@testing-library/dom, @popperjs/core, …) and broke `npm ci` in CI. Regenerated the lockfile with a plain full `npm install` (no legacy flag needed), so `npm ci` passes.
Runs npm ci + lint + next build on every pull request (and via manual dispatch) so broken builds are caught before merge.
TamimEhsan
had a problem deploying
to
github-pages
GitHub Actions
Failure
The deploy workflow used `on: push` with `branches: []`, which GitHub treats as no filter — so it ran on pushes to every branch (including PR branches). Restrict it to the master branch so it deploys only on merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CI workflow to validate the build passes and fixes the unsynced lockfile issue